Rename unified settings from "textEditor" to "language"#80309
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom Sep 16, 2025
Merged
Rename unified settings from "textEditor" to "language"#80309jasonmalinowski merged 1 commit intodotnet:mainfrom
jasonmalinowski merged 1 commit intodotnet:mainfrom
Conversation
This rename was applied to all the common settings (tab/spaces, etc) and is expected of us as well.
jasonmalinowski
commented
Sep 16, 2025
| Add(CompletionOptionsStorage.ShowItemsFromUnimportedNamespaces, "textEditor.csharp.intellisense.showCompletionItemsFromUnimportedNamespaces"). | ||
| Add(CompletionViewOptionsStorage.EnableArgumentCompletionSnippets, "textEditor.csharp.intellisense.enableArgumentCompletionSnippets"). | ||
| Add(CompletionOptionsStorage.ShowNewSnippetExperienceUserOption, "textEditor.csharp.intellisense.showNewSnippetExperience"); | ||
| Add(CompletionOptionsStorage.TriggerOnTypingLetters, "languages.csharp.intellisense.triggerCompletionOnTypingLetters"). |
Member
Author
There was a problem hiding this comment.
I'm making a note to dig into what these tests are adding here. It appears that for the most part it's just asserting the contents of the JSON match the contents of this, which doesn't actually catch bugs -- it just means you get to make every change twice. There is a bit of useful stuff though in it around checking resource strings, so I don't want to entirely delete it now.
CyrusNajmabadi
approved these changes
Sep 16, 2025
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rename was applied to all the common settings (tab/spaces, etc) and is expected of us as well.